Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support ......................................................................
Patch Set 20: (3 comments) https://gerrit.ovirt.org/#/c/48672/20/vdsm/v2v.py File vdsm/v2v.py: Line 648: for name in conn.listDefinedDomains(): Line 649: try: Line 650: vm = conn.lookupByName(name) Line 651: except libvirt.libvirtError as e: Line 652: logging.exception('Error in lookupByName(%s)' % name) logging.error, include e in the message Line 653: else: Line 654: seen.add(name) Line 655: yield vm Line 656: for vmid in conn.listDomainsID(): Line 656: for vmid in conn.listDomainsID(): Line 657: try: Line 658: vm = conn.lookupByID(vmid) Line 659: except libvirt.libvirtError as e: Line 660: logging.exception('Error in listDomainsID(%d)' % vmid) logging.error, include e in the message Line 661: else: Line 662: if vm.name() in seen: Line 663: continue Line 664: yield vm Line 659: except libvirt.libvirtError as e: Line 660: logging.exception('Error in listDomainsID(%d)' % vmid) Line 661: else: Line 662: if vm.name() in seen: Line 663: continue Here I would do: if vm.name() not in seen: yield vm Line 664: yield vm Line 665: Line 666: Line 667: def _add_vm(conn, vms, vm): -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
