Nir Soffer has posted comments on this change. Change subject: gluster: fix brick devices are created with incorrect data alignment ......................................................................
Patch Set 3: Code-Review-1 (1 comment) Seems too big and not clear if all the changes are related to what described in the commit message. Also the description is not very clear, what was the previous behavior, what was wrong with it, and what is the new behavior. Who is going to maintain this code? https://gerrit.ovirt.org/#/c/47959/3/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 73: if unitType == 'KiB': Line 74: return device.size.convertTo(spec='KiB') Line 75: else: Line 76: return device.size.convertTo(spec='MiB') Line 77: return 0 Is this related to the changes described in the commit message? If not, please separate to another patch. Line 78: Line 79: Line 80: def _getDeviceDict(device, createBrick=False): Line 81: info = {'name': device.name, -- To view, visit https://gerrit.ovirt.org/47959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Manoj Pillai <mpil...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
