Dan Kenigsberg has posted comments on this change. Change subject: network: caps vlan vlanid property has to be int ......................................................................
Patch Set 1: Code-Review+2 (1 comment) The tests should issue only int vlanid's! https://gerrit.ovirt.org/#/c/50729/1/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 257: else: Line 258: expected_iface = physical_iface Line 259: self.assertEquals(netinfo.networks[networkName]['iface'], Line 260: expected_iface) Line 261: if network_config.get('vlan') is not None: 'vlan' in config is simpler and clearer. But it needs to be fixed elsewhere too. Line 262: self.assertTrue(isinstance(network_config.get('vlan'), int)) Line 263: Line 264: def assertNetworkDoesntExist(self, networkName): Line 265: netinfo = self.vdsm_net.netinfo -- To view, visit https://gerrit.ovirt.org/50729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I737ae75e066ee27d5ecba0aa86118b94fd1ea62d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
