Ramesh N has uploaded a new change for review. Change subject: gluster: create bricks without MBR partitions ......................................................................
gluster: create bricks without MBR partitions During gluster brick creation, PVs should be created directly on the disks instead of MBR partitions to align the pvs correctly as per given RAID parameter. This patch will remove the _makePartition function and will not create parition as part of gluster brick creation. Bug-Url: https://bugzilla.redhat.com/1270792 Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae Signed-off-by: Ramesh Nachimuthu <[email protected]> --- M vdsm/gluster/storagedev.py 1 file changed, 1 insertion(+), 20 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/50769/1 diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py index 7ce4498..56815d1 100644 --- a/vdsm/gluster/storagedev.py +++ b/vdsm/gluster/storagedev.py @@ -137,24 +137,6 @@ return [blivetEnv.devicetree.getDeviceByName(devName.split("/")[-1]) for devName in devNameList] - def _makePartition(deviceList): - pvDeviceList = [] - doPartitioning = False - for dev in deviceList: - if dev.type not in ['disk', 'dm-multipath']: - pvDeviceList.append(dev) - else: - blivetEnv.initializeDisk(dev) - part = blivetEnv.newPartition(fmt_type="lvmpv", grow=True, - parents=[dev]) - blivetEnv.createDevice(part) - pvDeviceList.append(part) - doPartitioning = True - - if doPartitioning: - blivet.partitioning.doPartitioning(blivetEnv) - return pvDeviceList - def _createPV(deviceList, alignment=0): def _createAlignedPV(deviceList, alignment): for dev in deviceList: @@ -283,8 +265,7 @@ if inUseList: raise ge.GlusterHostStorageDeviceInUseException(inUseList) - pvDeviceList = _makePartition(deviceList) - pvDeviceList = _createPV(pvDeviceList, alignment) + pvDeviceList = _createPV(deviceList, alignment) vg = _createVG(vgName, pvDeviceList, raidParams.get('stripeSize', 0)) # The following calculation is based on the redhat storage performance doc -- To view, visit https://gerrit.ovirt.org/50769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ife980665ed76ad6040109990af978f4b833f98ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
