Ido Barkan has posted comments on this change. Change subject: net: MTU should be an integer all over VDSM. ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/50657/2/lib/vdsm/kernelconfig.py File lib/vdsm/kernelconfig.py: Line 199: Line 200: def _normalize_mtu(config_copy): Line 201: for net_attr in config_copy.networks.itervalues(): Line 202: if 'mtu' in net_attr: Line 203: # defensively convert to int so support upgrade path > Please add Done Line 204: net_attr['mtu'] = int(net_attr['mtu']) Line 205: else: Line 206: net_attr['mtu'] = mtus.DEFAULT_MTU Line 207: https://gerrit.ovirt.org/#/c/50657/2/lib/vdsm/network/api.py File lib/vdsm/network/api.py: Line 976: if 'mtu' not in attrs: : attrs['mtu'] = DEFAULT_MTU : else: : attrs['mtu'] = int(attrs['mtu']) > attrs['mtu'] = int(attrs['mtu']) if 'mtu' in attrs else DEFAULT_MTU Done -- To view, visit https://gerrit.ovirt.org/50657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7ba110d85b8ebd459c29ea438a68b8e55ccb1da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
