Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: ovs: use a class instead of NamedTuple for IPConfig ......................................................................
hooks: ovs: use a class instead of NamedTuple for IPConfig NamedTuples are evil, making code less readable. If we use class instead we not only transform it into a more readable code, but also store IPConfig values and handler inside one object (until now it was splitted into a named tuple and private function _gather_ip_config). Change-Id: Ic26e637d14e9542a65438f5e2b509abc20055ce2 Signed-off-by: Petr Horáček <[email protected]> Reviewed-on: https://gerrit.ovirt.org/49235 Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm_hooks/ovs/ovs_before_network_setup_ip.py 1 file changed, 12 insertions(+), 15 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic26e637d14e9542a65438f5e2b509abc20055ce2 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
