Ramesh N has uploaded a new change for review.

Change subject: gluster: ensure LV size is multiple of VG's PE value
......................................................................

gluster: ensure LV size is multiple of VG's PE value

  Size of LV should be multiple of PE value. But this calculation
was done only for RAID volume not for JBOD. With this patch
lv size calculation will be done always regardless of whether
its RAID or JBOD.

Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Bug-Url: https://bugzilla.redhat.com/1270792
Signed-off-by: Ramesh Nachimuthu <[email protected]>
---
M vdsm/gluster/storagedev.py
1 file changed, 3 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/50802/1

diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index 7f0501f..16430d2 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -262,16 +262,14 @@
     # a multiple of RAID stripe width if it is > minimum vg size
     # otherwise allocate a minimum of 0.5% of the data device size
     # and create data LV (poolDataSize) that has a size which is
-    # a multiple of stripe width
-    # For JBOD, this adjustment is not necessary
+    # a multiple of stripe width.
     vgSizeKib = int(_getDeviceSize(vg, 'KiB'))
     if _getDeviceSize(vg) < MIN_VG_SIZE:
         metaDataSizeKib = vgSizeKib * MIN_METADATA_PERCENT
     poolDataSize = vgSizeKib - metaDataSizeKib
 
-    if raidType:
-        metaDataSizeKib = (metaDataSizeKib - (metaDataSizeKib % alignment))
-        poolDataSize = (poolDataSize - (poolDataSize % alignment))
+    metaDataSizeKib = (metaDataSizeKib - (metaDataSizeKib % alignment))
+    poolDataSize = (poolDataSize - (poolDataSize % alignment))
 
     # Creating a thin pool from the data LV and the metadata LV
     # lvconvert --chunksize alignment --thinpool VOLGROUP/thin_pool


-- 
To view, visit https://gerrit.ovirt.org/50802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a1609544db36b16b5b8fc0a52d5ef04e770c18b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to