Idan Shaby has posted comments on this change. Change subject: fileSD: fix deleteImage flow ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/50804/1/vdsm/storage/fileSD.py File vdsm/storage/fileSD.py: Line 215: volPath = os.path.join(toDelDir, volUUID) Line 216: self._deleteFile("volume", volPath) Line 217: self._deleteFile("metadata", volPath + '.meta') Line 218: if self.hasVolumeLeases(): Line 219: self._deleteFile("lease", volPath + '.lease') > Before this patch, the flow will stop after the first failure. Here it will Yes Line 220: self.log.debug("Removing directory: %s", toDelDir) Line 221: try: Line 222: self.oop.os.rmdir(toDelDir) Line 223: except OSError as e: -- To view, visit https://gerrit.ovirt.org/50804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9eeb28a70f708a4f9a5effe4ff294da63b757369 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
