Laszlo Hornyak has posted comments on this change.
Change subject: Replace calling setSchedulerParameters() with filling its XML
description.
......................................................................
Patch Set 2: Verified; Looks good to me, but someone else must approve
(2 inline comments)
sorry for the long delay to review this patch.
It looks like working ok. some comments inline.
....................................................
File vdsm/libvirtvm.py
Line 712: vcpupin.setAttribute('cpuset', cpuPinning[cpuPin])
Line 713: cputune.appendChild(vcpupin)
Line 714: # Set Vm's niceness via setting cgroup cpu.shares
Line 715: nice = int(self.conf.get('nice', '0'))
Line 716: nice = max(min(nice, 19), -19)
19 and -19 would read better as maxNice and minNice constants.
Line 717: m = self.doc.createElement('shares')
Line 718: m.appendChild(self.doc.createTextNode(str((20 - nice) *
51)))
Line 719: cputune.appendChild(m)
Line 720: self.dom.appendChild(cputune)
Line 714: # Set Vm's niceness via setting cgroup cpu.shares
Line 715: nice = int(self.conf.get('nice', '0'))
Line 716: nice = max(min(nice, 19), -19)
Line 717: m = self.doc.createElement('shares')
Line 718: m.appendChild(self.doc.createTextNode(str((20 - nice) *
51)))
I do not completely understand this part, what is 51? why 51? Maybe another
talking constant name would help.
Line 719: cputune.appendChild(m)
Line 720: self.dom.appendChild(cputune)
Line 721:
Line 722: # This hack is for backward compatibility as the libvirt does
not allow
--
To view, visit http://gerrit.ovirt.org/6290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I211e191022f5a18fa7d97d5a8fb42e10729ddd06
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
