Nir Soffer has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/46269/13/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 156: self.coresSample[match.group(1)] = coreSample Line 157: Line 158: def getCoreSample(self, coreId): Line 159: strCoreId = str(coreId) Line 160: return self.coresSample.get(strCoreId) > The method already returned None. Only in case of a racecondition it would I agree that a bug fix should be minimal, but we want to fix this code to raise when there is no sample, simplifying the upper layer error handling. Would you send additional patch doing this? Line 161: Line 162: Line 163: class NumaNodeMemorySample(object): Line 164: """ -- To view, visit https://gerrit.ovirt.org/46269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Omer Frenkel <d.mosqu...@gmail.com> Gerrit-Reviewer: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
