Nir Soffer has posted comments on this change. Change subject: net tests: tcTests should run as root ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50794/2//COMMIT_MSG Commit Message: Line 6: Line 7: net tests: tcTests should run as root Line 8: Line 9: Mark that tcTests.TestConfigureOutbound tests should Line 10: run as root (otherwise, skip). > currently, these tests are already skipped, with a This is not a grand improvement :-) Currently the tests are skipped because they fail, this patch will skip them because they cannot succeed. Future patch can remove the skip on failures, making the test fail when it fails. Even if this patch changed nothing, declaring that a test requires root is a good change. Line 11: Line 12: Change-Id: I3a6d85dcb5ac6b0d842b2547e7ea8a91bc6a742c -- To view, visit https://gerrit.ovirt.org/50794 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a6d85dcb5ac6b0d842b2547e7ea8a91bc6a742c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
