Hello Nir Soffer, Sahina Bose, I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50852 to review the following change. Change subject: gluster add mount options for gluster brick. ...................................................................... gluster add mount options for gluster brick. Mount options "inode64,noatime" should be used to mount the gluster brick to improve the performance. Bug-Url: https://bugzilla.redhat.com/1270792 Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e Signed-off-by: Ramesh Nachimuthu <rnach...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/50770 Reviewed-by: Sahina Bose <sab...@redhat.com> Reviewed-by: Nir Soffer <nsof...@redhat.com> Continuous-Integration: Nir Soffer <nsof...@redhat.com> --- M vdsm/gluster/storagedev.py 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/50852/1 diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py index f19d959..8f50452 100644 --- a/vdsm/gluster/storagedev.py +++ b/vdsm/gluster/storagedev.py @@ -273,7 +273,8 @@ raise ge.GlusterHostStorageDeviceMkfsFailedException( thinlv.path, alignment, raidParams.get('stripeSize', 0), fsType) - format = blivet.formats.getFormat(DEFAULT_FS_TYPE, device=thinlv.path) + format = blivet.formats.getFormat(DEFAULT_FS_TYPE, device=thinlv.path, + mountopts=DEFAULT_MOUNT_OPTIONS) format._defaultFormatOptions = ["-f", "-i", "size=512", "-n", "size=8192"] if raidParams.get('type') == '6': format._defaultFormatOptions += ["-d", "sw=%s,su=%sk" % ( @@ -296,5 +297,6 @@ rc, out, err = utils.execCmd([_vgscanCommandPath.cmd]) if rc: raise ge.GlusterHostStorageDeviceVGScanFailedException(rc, out, err) - fstab.FsTab().add(thinlv.path, mountPoint, DEFAULT_FS_TYPE) + fstab.FsTab().add(thinlv.path, mountPoint, + DEFAULT_FS_TYPE, mntOpts=[DEFAULT_MOUNT_OPTIONS]) return _getDeviceDict(thinlv) -- To view, visit https://gerrit.ovirt.org/50852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id364837017ceb5a9506f4d9dd5092d6c9c4e7b7e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches