Petr Horáček has posted comments on this change.

Change subject: net: tests: test network's iface
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/48366/11/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 254:             if bridged is not None:
Line 255:                 self.assertEqual(network_config.get('bridged'), 
bridged)
Line 256:         physical_iface = (network_config.get('bonding') or
Line 257:                           network_config.get('nic'))
Line 258:         if network_config.get('bridged') is not False:
> I find 
Done
Line 259:             expected_iface = networkName
Line 260:         elif network_config.get('vlan') is not None:
Line 261:             expected_iface = '%s.%s' % (physical_iface,
Line 262:                                         network_config.get('vlan'))


-- 
To view, visit https://gerrit.ovirt.org/48366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If45fb63247b5e5b21721a23d8781a4ed80e58932
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Edward Haas <[email protected]>
Gerrit-Reviewer: Ido Barkan <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to