Yaniv Bronhaim has submitted this change and it was merged. Change subject: vm: fix misleading XML log ......................................................................
vm: fix misleading XML log When VDSM is asked to create a new VM, among the other things, it builds the domain XML according to the configuration sent by client (aka Engine) and run the before_vm_start hook. This is done also on the dehibernating (aka migration from file) path, for no apparent good reason. This is wasteful and useless at best, and most likely misleading, because VDSM logs the XML it produced, which is *not* what is gonna be used in the dehibernation path. This patch fixes this issue loggging the XML which is actually about to be fed to libvirt, not the useless one regenerated by VDSM. Backport-To: 3.6 Change-Id: I50f5b8a51830c8ce2a098e4ac11dd1bd6a89aac3 Bug-Url: https://bugzilla.redhat.com/1292371 Related-To: https://bugzilla.redhat.com/1190210 Related-To: https://bugzilla.redhat.com/1234197 Signed-off-by: Francesco Romani <from...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/44843 Reviewed-by: Dan Kenigsberg <dan...@redhat.com> Continuous-Integration: Dan Kenigsberg <dan...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/49139 Continuous-Integration: Jenkins CI Reviewed-by: Yaniv Bronhaim <ybron...@redhat.com> --- M vdsm/virt/vm.py 1 file changed, 16 insertions(+), 7 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/49139 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50f5b8a51830c8ce2a098e4ac11dd1bd6a89aac3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
