Adam Litke has posted comments on this change. Change subject: PoC: enforcement of contract for rpc ......................................................................
Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/50032/2/lib/api/vdsmapi-schema.yaml File lib/api/vdsmapi-schema.yaml: Line 17: # Refer to the README and COPYING files for full details of the license Line 18: # Line 19: Line 20: types: Line 21: # Specifies the type of fencing operation to perform Please put these comments as attributes of the schema itself. Maybe name these in such a manner that they can be easily stripped from a runtime object to save memory. Line 22: FenceNodeAction: &FenceNodeAction Line 23: type: enum Line 24: values: ['status', 'on', 'off', 'reboot'] Line 25: Line 18: # Line 19: Line 20: types: Line 21: # Specifies the type of fencing operation to perform Line 22: FenceNodeAction: &FenceNodeAction what does &FenceNodeAction mean. Line 23: type: enum Line 24: values: ['status', 'on', 'off', 'reboot'] Line 25: Line 26: # A mapping of hostId indexed by domain UUID Line 63: Line 64: # status of fence action executions for 'on', Line 65: # 'off' and 'reboot' actions Line 66: - name: operationStatus Line 67: type: *FenceNodeOperationStatusResult strip the leading * Line 68: defaultValue: "initiated" Line 69: added: 3.5 Line 70: Line 71: Line 113: type: *FencingPolicy Line 114: defaultValue: null Line 115: added: 3.5 Line 116: Line 117: return: *FenceNodeResult Strip the * -- To view, visit https://gerrit.ovirt.org/50032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia25c58fb7cb90fc74eceb902aa4748b0025cf96f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
