Shahar Havivi has posted comments on this change. Change subject: v2v: add test testSuccessfulImportOVA ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50585/2/tests/v2vTests.py File tests/v2vTests.py: Line 354: v2v.convert_ova(ovapath, self.vminfo, self.job_id, FakeIRS()) Line 355: job = v2v._jobs[self.job_id] Line 356: job.wait() Line 357: Line 358: self.assertEqual(job.status, v2v.STATUS.DONE) > Ensure job is deleted even if the assert fails. I'll put the v2v.convert_ova(...) inside the try block as well since this method creates the job Line 359: v2v.delete_job(self.job_id) Line 360: Line 361: def testV2VOutput(self): Line 362: cmd = [FAKE_VIRT_V2V.cmd, -- To view, visit https://gerrit.ovirt.org/50585 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I465d68e5f42f6f5829d33bf62c2d40412a8aead4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches