Liron Aravot has posted comments on this change. Change subject: storage: perform image deletion in task ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/48477/4/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 1539 Line 1540 Line 1541 Line 1542 Line 1543 > This comment explains why we delete the images in the synchronous state - w we still rename the image synchronously (which essentially deletes it), don't you prefer to leave the comment? Line 1532: else: Line 1533: if fakeTUUID: Line 1534: tParams = dom.produceVolume(imgUUID, fakeTUUID).\ Line 1535: getVolumeParams() Line 1536: > will be removed Done Line 1537: pool.deleteImage(dom, imgUUID, volsByImg) Line 1538: # This is a hack to keep the interface consistent Line 1539: # We currently have race conditions in delete image, to quickly fix Line 1540: # this we delete images in the "synchronous" state. This only works -- To view, visit https://gerrit.ovirt.org/48477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e61d38439192d193f3f806e08661b61a65e7836 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
