Dan Kenigsberg has posted comments on this change. Change subject: Import CPopen and IOStream only in python2 to allow test runs ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/50902/1/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 56: sys.version this is correct, but quite ugly. if sys.version_info >= (2, 0, 0) is much much prettier -- To view, visit https://gerrit.ovirt.org/50902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ece01ef331fead19e497ac2015955e299907efd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
