Shahar Havivi has posted comments on this change. Change subject: v2v: extract specific classes for libvirt and ova ......................................................................
Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/49951/9/vdsm/v2v.py File vdsm/v2v.py: Line 360 Line 361 Line 362 Line 363 Line 364 > Job must implement this. Done Line 278: Line 279: Line 280: class V2VCommand(object): Line 281: def __init__(self, uri, vminfo, vmid, irs): Line 282: self._uri = uri > uri does not belong here it should be parameter of LibvirtCommand. Done Line 283: self._vminfo = vminfo Line 284: self._vmid = vmid Line 285: self._irs = irs Line 286: self._prepared_volumes = [] Line 416: self._vmid, self._passwd_file) Line 417: Line 418: Line 419: class OvaCommand(V2VCommand): Line 420: def __init__(self, ova_path, vminfo, vmid, irs): > Keep the order of arguments same as the super class, adding the specific ar no its not the V2VCommand ignore the uri. I am removing it from V2vCommand. Line 421: super(self.__class__, self).__init__(ova_path, vminfo, vmid, irs) Line 422: self._ova_path = ova_path Line 423: Line 424: def _command(self): -- To view, visit https://gerrit.ovirt.org/49951 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9ecd4a2cde6f379188da647c3a6f8874c41abd Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
