Nir Soffer has uploaded a new change for review. Change subject: jobs: Remove unused method ......................................................................
jobs: Remove unused method Nobody is calling Job.validate_done(), and I don't want to add test for code that we don't need. Change-Id: I9107b7eabeb70569be967df2ef1d78f996219370 Signed-off-by: Nir Soffer <nsof...@redhat.com> --- M lib/vdsm/jobs.py 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/51214/1 diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py index 549028a..008c100 100644 --- a/lib/vdsm/jobs.py +++ b/lib/vdsm/jobs.py @@ -112,10 +112,6 @@ logging.info('Job %r aborting...', self._id) self._abort() - def validate_done(self): - if self.status != STATUS.DONE: - raise JobNotDone("Job %r is %s" % (self.id, self.status)) - def validate_not_active(self): if self.status not in (STATUS.DONE, STATUS.ABORTED, STATUS.FAILED): raise JobNotDone("Job %r is %s" % (self.id, self.status)) -- To view, visit https://gerrit.ovirt.org/51214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9107b7eabeb70569be967df2ef1d78f996219370 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches