Yaniv Bronhaim has submitted this change and it was merged.
Change subject: iscsi: Fix credentials initialization when not using CHAP
......................................................................
iscsi: Fix credentials initialization when not using CHAP
There was a mismatch between the way we initialize ChapCredentials when
receiving empty credentials from engine, and when reading empty
credentials from active session.
This was broken when we started to protect password with
ProtectedPassword. When getting a request from engine we used
ProtectedPassword(""), while the iscsi code used None. This causes
session disconnect to fail with "cred mismatch".
Now we have a note explaining the dependency and we use the same way to
initialize the credentials:
- When receiving request from engine, empty username or password are
stored as None.
- When reading requests from active session, empty username or password
are stored as None, including the special empty values "<NULL>" and
"(null)".
Code was moved so username and password normalization is near
ChapCredentials initialization in both flows.
Change-Id: I65e1177bc33998b8eba34b0fd04ec62cf8bf1a2c
Bug-Url: https://bugzilla.redhat.com/1279485
Reported-By: Elad Ben Aharon <[email protected]>
Signed-off-by: Nir Soffer <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/48483
Reviewed-by: Freddy Rolland <[email protected]>
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/50940
Reviewed-by: Allon Mureinik <[email protected]>
Reviewed-by: Yaniv Bronhaim <[email protected]>
---
M vdsm/storage/hsm.py
M vdsm/storage/iscsi.py
2 files changed, 21 insertions(+), 10 deletions(-)
Approvals:
Nir Soffer: Verified
Yaniv Bronhaim: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50940
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65e1177bc33998b8eba34b0fd04ec62cf8bf1a2c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
