Nir Soffer has posted comments on this change. Change subject: JSONRPC: make Image.prepare to return info. ......................................................................
Patch Set 4: (7 comments) https://gerrit.ovirt.org/#/c/51054/4/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 5217: # Line 5218: # @volumeID: The UUID of the Volume Line 5219: # Line 5220: # Returns: Line 5221: # Image relevant info. Add new in version here: Returns: Information about prepared image (new in version 4.18) Line 5222: # Line 5223: # Since: 4.17.0 Line 5224: ## Line 5225: {'command': {'class': 'Image', 'name': 'prepare'}, Line 5219: # Line 5220: # Returns: Line 5221: # Image relevant info. Line 5222: # Line 5223: # Since: 4.17.0 This verb did exist in 4.15, so there is no need to change this. Line 5224: ## Line 5225: {'command': {'class': 'Image', 'name': 'prepare'}, Line 5226: 'data': {'storagepoolID': 'UUID', 'storagedomainID': 'UUID', Line 5227: 'imageID': 'UUID', 'volumeID': 'UUID'} Line 5239: # @imageID: The UUID of the Image Line 5240: # Line 5241: # @volumeID: #optional The UUID of the Volume (optional) Line 5242: # Line 5243: # Since: 4.17.0 Nothing was changed in this verb, so no need to change the version. Line 5244: ## Line 5245: {'command': {'class': 'Image', 'name': 'teardown'}, Line 5246: 'data': {'storagepoolID': 'UUID', 'storagedomainID': 'UUID', Line 5247: 'imageID': 'UUID', '*volumeID': 'UUID'}} Line 5246: 'data': {'storagepoolID': 'UUID', 'storagedomainID': 'UUID', Line 5247: 'imageID': 'UUID', '*volumeID': 'UUID'}} Line 5248: Line 5249: ## Line 5250: # @ImageInfo: Most (all?) types here appear before the verbs using them. Lets keep this style. Line 5251: # Line 5252: # Information about an Image. Line 5253: # Line 5254: # @path: The Image Path Line 5248: Line 5249: ## Line 5250: # @ImageInfo: Line 5251: # Line 5252: # Information about an Image. Information about a prepared image Line 5253: # Line 5254: # @path: The Image Path Line 5255: # Line 5256: # Since: 4.17.0 Line 5250: # @ImageInfo: Line 5251: # Line 5252: # Information about an Image. Line 5253: # Line 5254: # @path: The Image Path The image path Line 5255: # Line 5256: # Since: 4.17.0 Line 5257: ## Line 5258: {'type': 'ImageInfo', Line 5252: # Information about an Image. Line 5253: # Line 5254: # @path: The Image Path Line 5255: # Line 5256: # Since: 4.17.0 4.18 Line 5257: ## Line 5258: {'type': 'ImageInfo', Line 5259: 'data': {'path': 'str'}} Line 5260: -- To view, visit https://gerrit.ovirt.org/51054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc03568b35c14e1f5c7239c8c3df8f74acf3ec51 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
