Francesco Romani has posted comments on this change.

Change subject: fileSD: improve error handling in deleteImage
......................................................................


Patch Set 1:

(1 comment)

codewise seems ok, and has ACKs from storage devs. I have a question about 
backport process, trying to streamline it as much as we can.

https://gerrit.ovirt.org/#/c/51299/1//COMMIT_MSG
Commit Message:

Line 19: the others.  Now we handle each removal separately, so that a failure 
in
Line 20: the removal of one file doesn't affect the removal of the others.
Line 21: 
Line 22: This patch is a backport for patch
Line 23: I9eeb28a70f708a4f9a5effe4ff294da63b757369 which was reverted.
what happens if you use this change-id? Does gerrit refuse the patch?
Line 24: 
Line 25: Change-Id: I22ceee059cce1ec65cd455ce567cba0e49c00db2
Line 26: Bug-Url: https://bugzilla.redhat.com/1292092
Line 27: Signed-off-by: Idan Shaby <[email protected]>


-- 
To view, visit https://gerrit.ovirt.org/51299
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22ceee059cce1ec65cd455ce567cba0e49c00db2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Idan Shaby <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Idan Shaby <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to