Dan Kenigsberg has posted comments on this change. Change subject: vm: restoring correct vm nic device after HotunplugTimeout ......................................................................
Patch Set 3: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/51187/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2328: return {'status': doneCode, 'vmList': self.status()} Line 2329: Line 2330: # Restore NIC device in vm's conf and _devices Line 2331: def _rollback_nic_hotunplug(self, nic_dev, nic): Line 2332: if nic_dev: no problem. Line 2333: with self._confLock: Line 2334: self.conf['devices'].append(nic_dev) Line 2335: if nic: Line 2336: self._devices[hwclass.NIC].append(nic) -- To view, visit https://gerrit.ovirt.org/51187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1055a9c6b19143edf98da7f82459d96f3a406712 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
