Ryan Harper has posted comments on this change. Change subject: migrateStatus() progress report ......................................................................
Patch Set 6: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/vm.py Line 103: """ Line 104: Get the status of the migration. Line 105: """ Line 106: try: Line 107: # get a libvirt connection This is a nit pick, but we're not getting a connection, but rather a reference to the VM instance. Line 108: libvirtVm = self._connection.lookupByUUID(self._vm.id) Line 109: # jobInfo reference: http://libvirt.org/html/libvirt-libvirt.html#virDomainJobInfo Line 110: (dataTotal, dataProcessed, dataRemaining) = libvirtVm.jobInfo()[3:6] Line 111: # get transfer percentage -- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
