Yaniv Bronhaim has posted comments on this change. Change subject: Remove usage of deathSignal ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/48121/3/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 201 Line 202 Line 203 Line 204 Line 205 here also we need to guard the process https://gerrit.ovirt.org/#/c/48121/3/vdsm/storage/imageSharing.py File vdsm/storage/imageSharing.py: Line 94 Line 95 Line 96 Line 97 Line 98 > This is a good example of the code needed when using execCmd in async mode. second choice fits better. many places hold the asyncProc instance and use it all over. we can also decorate the functions in aysnProc with the try except clause. no? https://gerrit.ovirt.org/#/c/48121/3/vdsm/v2v.py File vdsm/v2v.py: Line 426: logging.info('Job %r starting import', self._id) Line 427: Line 428: # This is the way we run qemu-img convert jobs. virt-v2v is invoking Line 429: # qemu-img convert to perform the migration. Line 430: self._proc = execCmd(cmd, sync=False, also need protection Line 431: nice=NICENESS.HIGH, ioclass=IOCLASS.IDLE, Line 432: env=self._execution_environments()) Line 433: Line 434: self._proc.blocking = True -- To view, visit https://gerrit.ovirt.org/48121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice7fc30ec90adf8055eb35a8c67c07f514030265 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
