Adam Litke has posted comments on this change. Change subject: storage: Split newMetadata into makeMetadata and createMetadata ......................................................................
Patch Set 14: (2 comments) https://gerrit.ovirt.org/#/c/44045/14/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 522 Line 523 Line 524 Line 525 Line 526 > This separation makes sense, although I did not see the other place using t It will be used by the volume artifacts when creating a new volume. Line 533: return meta Line 534: Line 535: @classmethod Line 536: def makeMetadata(cls, sdUUID, imgUUID, puuid, size, format, type, Line 537: voltype, disktype, desc="", legality=ILLEGAL_VOL): > The name is confusing. This return a metadata dict that can be used to crea new_metadata_dict Line 538: """ Line 539: Produce a metadata dictionary from a set of arguments. Line 540: """ Line 541: return { -- To view, visit https://gerrit.ovirt.org/44045 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
