Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Add getParentVolume ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/44042/13/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 559: puuid = self.getParent() Line 560: if puuid and puuid != BLANK_UUID: Line 561: sd_manifest = sdCache.produce(self.sdUUID).manifest Line 562: return sd_manifest.produceVolume(self.imgUUID, puuid) Line 563: return None > Yes. I cannot think of a better way to do this. Can you? This should raise something like NoParentVolume, but I don't want to redesign old code now. Is this called by old code? Do we need this patch for the first step of create_volume? If not, lets leave it for now and add it when we need it. Line 564: Line 565: Line 566: class Volume(object): Line 567: log = logging.getLogger('Storage.Volume') -- To view, visit https://gerrit.ovirt.org/44042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74def8861e0b7b97ca4d218a969440ccba7f07dd Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
