Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Separate tests using permutations
......................................................................
tests: Separate tests using permutations
GuestAgent tests were using one test method for multiple tests, so
failing of one test would fail other unrelated tests. Use permutations
to have one test method per test.
Also group filtering tests under TestFiltering test case class.
Here is an example run of the new test class:
guestagentTests.TestFiltering
test_filter_object_invalid OK
test_filter_object_valid OK
test_filter_xml_chars_replace_invalid(u'\ud800') OK
test_filter_xml_chars_replace_invalid(u'\udc79') OK
test_filter_xml_chars_replace_invalid(u'\ufffe') OK
test_filter_xml_chars_replace_invalid(u'\uffff') OK
test_filter_xml_chars_replace_invalid(u'\x00') OK
test_filter_xml_chars_replace_restricted OK
test_filter_xml_chars_valid(u'') OK
test_filter_xml_chars_valid(u'\u2122') OK
test_filter_xml_chars_valid(u'ascii') OK
Change-Id: I8cf598bd6788e9d38123938b9b2a4a70e764f349
Signed-off-by: Nir Soffer <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/50941
Reviewed-by: Vinzenz Feenstra <[email protected]>
Reviewed-by: Francesco Romani <[email protected]>
---
M tests/guestagentTests.py
1 file changed, 37 insertions(+), 26 deletions(-)
Approvals:
Nir Soffer: Verified; Passed CI tests
Vinzenz Feenstra: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, approved
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/50941
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cf598bd6788e9d38123938b9b2a4a70e764f349
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
