Francesco Romani has posted comments on this change. Change subject: tests: improve vmstats.disks coverage ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/50598/1/tests/vmStatsTests.py File tests/vmStatsTests.py: Line 386: 'writtenBytes', Line 387: ) Line 388: Line 389: # this is what old VDSM did. No clear rationale. Line 390: _MINIMAL_KEYS = ( > none. I was fooled by different ordering. I was fooled *twice* by different ordering. The difference is that here we don't have {read,write}Rate. But I'll find a better solution than duplicating almost the entire set. Line 391: 'apparentsize', Line 392: 'flushLatency', Line 393: 'imageID', Line 394: 'readBytes', -- To view, visit https://gerrit.ovirt.org/50598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I931d080d66b8a6087b05f01fbdce8fee0cd99039 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
