Vinzenz Feenstra has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51521/1/vdsm/virt/vmchannels.py File vdsm/virt/vmchannels.py: Line 50: Line 51: def _unregister_fd(self, fileno): Line 52: try: Line 53: self._epoll.unregister(fileno) Line 54: except IOError as e: > when do we possibly get to ENOENT? Do you remember 'Unregister called twice?' ? I actually think that this cannot happen anymore after the changes we did now. so if it makes you happy I can log it, but I can't tell if it is common or not. So don't blame me if it is going to spam the logs. Line 55: if e.errno != errno.ENOENT: Line 56: raise Line 57: Line 58: def _handle_event(self, fileno, event): -- To view, visit https://gerrit.ovirt.org/51521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f7eab8318f41f653e0a24552c81bcd5b09d8690 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
