Yaniv Kaul has posted comments on this change. Change subject: Implement SSL session cache ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/SecureXMLRPCServer.py Line 70: SSL.VERIFY_CLIENT_ONCE, Line 71: SSLServerSocket.verify) Line 72: Line 73: @staticmethod Line 74: def verify(connection, certificate, x, y, z): I thought 'z' is actually return code and should be checked. See http://twistedmatrix.com/documents/current/core/howto/ssl.html#auto8 or http://stackoverflow.com/questions/9089957/validating-client-certificates-in-pyopenssl Line 75: # No need for additional verifications: Line 76: return True Line 77: Line 78: def __getattr__(self, name): -- To view, visit http://gerrit.ovirt.org/8123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic75adee4070b415b8855af1f2ea289825496fbc1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
