Tal Nisan has uploaded a new change for review. Change subject: Alignment scans will now run in direct mode ......................................................................
Alignment scans will now run in direct mode Currently on RHEL 7 and Fedora 22 or later alignment scan via libguestfs does not work by going through libvirt and only works directly. As a workaround this patch runs the alignment scan with an environment variable that tells libguestfs to run the scan directly and not through libvirt. While this solution works it should be reverted after the libvirt bug will be solved as it is a workaround, since we allow only VMs in down status to be scanned it does not have an affect but once we would like to allow scans on running VMs the fact that we bypassing libvirt will mark the VMs as tainted. Bug-Url: https://bugzilla.redhat.com/1151838 Change-Id: I00d8b681e4d2a2f4fb60e673eefdc807d8e1447d Signed-off-by: Tal Nisan <[email protected]> --- M vdsm/alignmentScan.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/51619/1 diff --git a/vdsm/alignmentScan.py b/vdsm/alignmentScan.py index e71a408..7b1b033 100644 --- a/vdsm/alignmentScan.py +++ b/vdsm/alignmentScan.py @@ -40,7 +40,10 @@ def runScanArgs(*args): cmd = [_virtAlignmentScan.cmd] cmd.extend(args) - return execCmd(cmd) + # TODO: remove the environment variable when the issue in + # virt-alignment-scan/libvirt is resolved + # http://bugzilla.redhat.com/1151838 + return execCmd(cmd, env={'LIBGUESTFS_BACKEND': 'direct'}) def scanImage(image_path): -- To view, visit https://gerrit.ovirt.org/51619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I00d8b681e4d2a2f4fb60e673eefdc807d8e1447d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
