Fabian Deutsch has posted comments on this change. Change subject: tests: Fix loop device leak in mount tests ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51614/1/tests/mountTests.py File tests/mountTests.py: Line 131: m.mount(mntOpts="loop") Line 132: try: Line 133: self.assertTrue(m.isMounted()) Line 134: finally: Line 135: m.umount(force=True, freeloop=True) > Ok, but that means that the operation may fail. Yep - Failing is better than silently ignoring it (which lazy would do) Line 136: # TODO: Use libudev to wait for specific event Line 137: with stopwatch("Wait for udev events"): Line 138: udevadm.settle(5) Line 139: -- To view, visit https://gerrit.ovirt.org/51614 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iada8f3d962778c53ada4a6f0a7f3e75b80c07239 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
