Dan Kenigsberg has posted comments on this change. Change subject: Add deathSignal options to better popen ......................................................................
Patch Set 11: Fails (3 inline comments) `make check-local` fails. .................................................... File tests/betterPopenTests.py Line 150: p.wait() Line 151: self.assertTrue(p.returncode == 0, Line 152: "Process failed: %s" % os.strerror(p.returncode)) Line 153: Line 154: self.assertEquals(p.stdout.read(), data) a pep8 fairy just died. Line 155: def testDeathSignal(self): Line 156: procPtr = [None] Line 157: def spawn(): Line 158: procPtr[0] = BetterPopen(["sleep", "10"], deathSignal=signal.SIGKILL) Line 152: "Process failed: %s" % os.strerror(p.returncode)) Line 153: Line 154: self.assertEquals(p.stdout.read(), data) Line 155: def testDeathSignal(self): Line 156: procPtr = [None] this pointer trick should have an auto-completion rule for adding a comment... Line 157: def spawn(): Line 158: procPtr[0] = BetterPopen(["sleep", "10"], deathSignal=signal.SIGKILL) Line 159: t = threading.Thread(target=spawn) Line 160: t.start() Line 154: self.assertEquals(p.stdout.read(), data) Line 155: def testDeathSignal(self): Line 156: procPtr = [None] Line 157: def spawn(): Line 158: procPtr[0] = BetterPopen(["sleep", "10"], deathSignal=signal.SIGKILL) and another one here. Line 159: t = threading.Thread(target=spawn) Line 160: t.start() Line 161: t.join() Line 162: start = time.time() -- To view, visit http://gerrit.ovirt.org/6241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
