Milan Zamazal has posted comments on this change. Change subject: virt: Don't create <bios> on non-x86 architectures ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51648/1/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 243: <cmdline>ARGs 1</cmdline> Line 244: <smbios mode="sysinfo"/> Line 245: </os> Line 246: Line 247: If 'use_serial_console' is true and we are on x86 (not ppc), use the > I'd just say "and we are on x86", but not very important. Done Line 248: console: Line 249: Line 250: <os> Line 251: ... -- To view, visit https://gerrit.ovirt.org/51648 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5912d9842d46c3fcbefc7e668912706af25c45fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
