Piotr Kliczewski has posted comments on this change. Change subject: hooks: make sure that hook error inherits from vdsm exception ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51549/3/lib/vdsm/hooks.py File lib/vdsm/hooks.py: Line 33: from . import utils Line 34: from .constants import P_VDSM_HOOKS, P_VDSM Line 35: Line 36: Line 37: class HookError(exception.GeneralException): > What about moving this exception to vdsm.execption? Looks good to me. Is there any one who would like to keep it here? Line 38: code = 1500 Line 39: message = "Hook Error" Line 40: Line 41: -- To view, visit https://gerrit.ovirt.org/51549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9c0e953f96827737eede22ab39a1f7689c30944 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
