Francesco Romani has posted comments on this change.

Change subject: virt: Correct epoll unregistration usage in vmchannels
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/51521/7//COMMIT_MSG
Commit Message:

Line 20: 
Line 21: This patch fixes those two scenarios.
Line 22: 
Line 23: Change-Id: I9f7eab8318f41f653e0a24552c81bcd5b09d8690
Line 24: Backport-To: 3.5
It is ok, but next time let's make this explicit:

Backport-To: 3.6
Backport-To: 3.5

What you added implicates the above because we DON'T have
the downstream-only label.
And yes, all of this tag usage and meaning should be documented better (e.g. 
wiki, will add a note on my TODO)
Line 25: Bug-Url: https://bugzilla.redhat.com/1226911


-- 
To view, visit https://gerrit.ovirt.org/51521
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f7eab8318f41f653e0a24552c81bcd5b09d8690
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Gal Hammer <ghammer%[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to