Edward Haas has posted comments on this change. Change subject: operstate: use python3-friendly io.open() ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/51736/1/tests/netinfoTests.py File tests/netinfoTests.py: Line 105: io I think it will be cleaner to use six here: from six.moves import builtins Then use builtins instead of __builtins__ No need to change the production code. -- To view, visit https://gerrit.ovirt.org/51736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I877f01bf1fb79a7fbbe44416a70645b1da4afd01 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
