Nir Soffer has posted comments on this change. Change subject: conflib: Introduce the conflib library ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40960/5/lib/vdsm/conflib.py File lib/vdsm/conflib.py: Line 129: section = value() Line 130: section.name = name Line 131: setattr(self, name, section) Line 132: Line 133: def _load(self, parser): This is ugly. Loading should be done by another class, setting values on a config instance instead. Line 134: """ Line 135: Load configuration from ConfigParser instance. Line 136: """ Line 137: for name in parser.sections(): -- To view, visit https://gerrit.ovirt.org/40960 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1882274f386852960ab3c785193449ab1367fec8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
