Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Correct epoll unregistration usage in vmchannels ......................................................................
virt: Correct epoll unregistration usage in vmchannels Previously we have been unregistering fds from epoll but not in the correct way. Which has led to log messages which seemed to have no good explanation as of why they occur. That has been changed to 'fix' it by letting only epoll unregister those file descriptors themselves when they are closed. This however has been wrong - the correct procedure to use epoll is to unregister the file descriptor first and then close the socket. In the vmchannel case there are two scenarios where this applies: - On an error reported by epoll - When we want to unregister the channel from vmchannels This patch fixes those two scenarios. Change-Id: I9f7eab8318f41f653e0a24552c81bcd5b09d8690 Backport-To: 3.5 Backport-To: 3.6 Bug-Url: https://bugzilla.redhat.com/1226911 Signed-off-by: Vinzenz Feenstra <[email protected]> Reviewed-on: https://gerrit.ovirt.org/51521 Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Michal Skrivanek <[email protected]> Continuous-Integration: Nir Soffer <[email protected]> Reviewed-by: Nir Soffer <[email protected]> Continuous-Integration: Jenkins CI --- M vdsm/virt/vmchannels.py 1 file changed, 31 insertions(+), 4 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve; Passed CI tests Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified Francesco Romani: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f7eab8318f41f653e0a24552c81bcd5b09d8690 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
