Vinzenz Feenstra has posted comments on this change. Change subject: utils: add weakmethod helper ......................................................................
Patch Set 4: Code-Review-1 (1 comment) -1 for visibility https://gerrit.ovirt.org/#/c/51865/4/tests/utilsTests.py File tests/utilsTests.py: Line 1057: Line 1058: self.assertIn(FakeVirDomain, Line 1059: (inst.__class__ for inst in (after - before))) Line 1060: Line 1061: def test_without_reference_cycle(self): well I am not sure I like this, but you're duplicating the code here, couldn't you just move it into another method and call it from the test_* methods with the parameters _broken_wrapper / utils.weekmethod? Line 1062: Line 1063: # test environment is too noisy Line 1064: gc.collect() Line 1065: before = set(gc.garbage) -- To view, visit https://gerrit.ovirt.org/51865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f26aa314e26142122e9f594275406cf7fbade98 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
