Francesco Romani has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/51630/8/lib/vdsm/libvirtconnection.py File lib/vdsm/libvirtconnection.py: Line 166: setattr(conn, 'pingLibvirt', getattr(conn, 'getLibVersion')) Line 167: for name in dir(libvirt.virConnect): Line 168: method = getattr(conn, name) Line 169: if callable(method) and name[0] != '_': Line 170: setattr(conn, name, wrapMethod(method)) > Shouldn't this use utils.weakmethod as well? libvirt.virConnect also contai Yes, won't hurt. Will do in a different patch. Line 171: if target is not None: Line 172: for ev in (libvirt.VIR_DOMAIN_EVENT_ID_LIFECYCLE, Line 173: libvirt.VIR_DOMAIN_EVENT_ID_REBOOT, Line 174: libvirt.VIR_DOMAIN_EVENT_ID_RTC_CHANGE, -- To view, visit https://gerrit.ovirt.org/51630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06607e63d222bf3f8037f2bda115b48feb94cb1c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
