Dan Kenigsberg has posted comments on this change.
Change subject: vdsmd.init: verify if libvirt socket file exists
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/vdsmd.init.in
Line 401: # this workaround should be removed.
Line 402:
Line 403: for i in {1..50}
Line 404: do
Line 405: if [[ -S /var/run/libvirt/libvirt-sock ]] && [[ `pgrep
libvirtd` ]]; then
was this actually verified?
[[ -S /var/run/libvirt/libvirt-sock ]] && pgrep libvirtd > /dev/null 2>&1
would have been syntactically better.
p.s. you know how much I love short lines...
Line 406: return 0
Line 407: fi
Line 408: sleep 0.2
Line 409: done
--
To view, visit http://gerrit.ovirt.org/8175
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ada84192a639c7780c40d7df62e22e3c9fa9e16
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
