Nir Soffer has posted comments on this change. Change subject: utils: add weakmethod helper ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/51865/8/tests/utilsTests.py File tests/utilsTests.py: Line 1043: gc.collect() Line 1044: has_leak = ( Line 1045: len(gc.garbage) == 1 and Line 1046: ObjectWithDel == type(gc.garbage[0]) Line 1047: ) > The check looks better and more correct, but now permutation lost its sense This is why I suggested to avoid permutations in this case :-) Line 1048: self.assertEquals(has_leak, leak_expected) Line 1049: Line 1050: def test_raise_on_invalid_weakref(self): Line 1051: obj = ObjectWithDel() -- To view, visit https://gerrit.ovirt.org/51865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f26aa314e26142122e9f594275406cf7fbade98 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
