Edward Haas has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping ......................................................................
Patch Set 1: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py: Line 148: return ['--', 'set', 'Bridge', BRIDGE_NAME, Line 149: 'stp_enable=%s' % str(stp).lower()] Line 150: Line 151: Line 152: def _set_aa_mapping(network, attrs, running_config): It's a bit complex to read what the func does, it will be nice to use something like this: if not _aa_mapping_configured() __aa_mapping_delete() _aa_mapping_update(sid, vlan) def _aa_mapping_configured(sid, vlan): if sid is None: return ... Line 153: """Handle OVS Auto-Attach mapping""" Line 154: command = [] Line 155: init_sid = rget(running_config.networks, (network, 'custom', 'ovs_aa_sid')) Line 156: init_vlan = rget(running_config.networks, (network, 'vlan')) Line 155: running_config In the future, it will be safer to read ovs actual settings. Like we do with kernelconfig. Line 165: running_config.bonds.get(attrs['bonding'])['nics'] Based on ovs-vsctl man: "These commands treat a bonded port as a single entity." So do we need to touch the port representing the bond or not the slave ports? Line 168: command.extend(['--', 'set', 'Interface', interface, : 'lldp:enable=true']) Can you please add a reference to where this settings are documented? I could not locate it in the man, saw it only in vswitch.xml. -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0eaf7ee8b3f3027154df8f6c30a45d4b45c14e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
