Peter V. Saveliev has posted comments on this change. Change subject: [WIP] BZ#855922, fix attribute error during migration ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/vm.py Line 59: def __init__(self, conf, log, **kwargs): Line 60: for attr, value in kwargs.iteritems(): Line 61: try: Line 62: setattr(self, attr, value) Line 63: except: I think, almost all possible exceptions here will be AttributeError, even if we will try to set up attr with — e.g. — NoneType as name (not value). But I should check firstly. The main question now is which way to choose: this or /8185. Line 64: # skip read-only poperties Line 65: pass Line 66: self.conf = conf Line 67: self.log = log -- To view, visit http://gerrit.ovirt.org/8186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cd2ffaa3221f37af968df38ba8bcd285e25122d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
