Francesco Romani has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail ......................................................................
Patch Set 10: (1 comment) looks nice, but no tests? https://gerrit.ovirt.org/#/c/51407/10//COMMIT_MSG Commit Message: Line 11: The following code for example guaranties that process will be cleaned and exit Line 12: after timeout without handling the kill call. If process will stay alive Line 13: after sigkill, "terminating" will register the process pid to zombiereaper. Line 14: Line 15: p = execCmd([cmd], sync=False) shouldn't be `proc' instead of `p'? Line 16: with terminating(p): Line 17: if proc.wait(30) is None: Line 18: raise Timeout() Line 19: -- To view, visit https://gerrit.ovirt.org/51407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I003cce39d62dba5644937fafaf2c6e24c526c075 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
