Francesco Romani has posted comments on this change. Change subject: vm: delete recovery file only after destroy() ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51799/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3892: del self.cif.vmContainer[self.conf['vmId']] Line 3893: except KeyError: Line 3894: self.log.exception("Failed to delete VM %s", self.conf['vmId']) Line 3895: else: Line 3896: self._cleanupRecoveryFile() > Can it happen that VM disappears from vmContainer elsewhere, so we don't ca No, deleteVm is the only place on which we do this removal. Line 3897: self.log.debug("Total desktops after destroy of %s is %d", Line 3898: self.conf['vmId'], len(self.cif.vmContainer)) Line 3899: Line 3900: def destroy(self): -- To view, visit https://gerrit.ovirt.org/51799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9513a72041e9514fd3aed8b2292f2ebdea4a03ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
