Nir Soffer has posted comments on this change. Change subject: resourceManager: Fix ResourceRef leak ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51917/3/vdsm/storage/resourceManager.py File vdsm/storage/resourceManager.py: Line 297: continue Line 298: Line 299: weakmethod = partial(ResourceRef.__methodProxy, Line 300: weakref.proxy(self), attr) Line 301: setattr(self, attr, weakmethod) > looks good. For my understanding, you can't use our new utils.weakmethod() Right, that was my first attempt, doing one line patch with the new shiny weakmethod, but it does not work with partial, which is not a method. Line 302: Line 303: def __methodProxy(self, attr, *args, **kwargs): Line 304: with self._syncRoot.shared: Line 305: if not self.isValid: -- To view, visit https://gerrit.ovirt.org/51917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I890616ba53ee70688ee00ea337ebc566d63f861d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
